Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Project Descriptor(project.toml) Converter #182

Closed
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8435e34
draft
haliliceylan Aug 10, 2021
a6ab15c
last
haliliceylan Aug 10, 2021
429c841
Update text/0000-project-toml-converter.md
haliliceylan Aug 12, 2021
4e93a27
CNB_PLATFORM_API
haliliceylan Aug 13, 2021
93b2bd0
motivation prepare phase
haliliceylan Aug 13, 2021
ca270f3
motivation paraphraph 2
haliliceylan Aug 13, 2021
f1aa294
What it is
haliliceylan Aug 13, 2021
9002b56
natalie author
haliliceylan Aug 13, 2021
b56261d
project toml example
haliliceylan Aug 15, 2021
bde82fa
some changes
haliliceylan Aug 15, 2021
86e16cb
Update text/0000-project-toml-converter.md
haliliceylan Aug 16, 2021
077ef6f
Update text/0000-project-toml-converter.md
haliliceylan Aug 16, 2021
ee7363c
Update text/0000-project-toml-converter.md
haliliceylan Aug 16, 2021
a1b591d
Update text/0000-project-toml-converter.md
haliliceylan Aug 16, 2021
54acf19
Apply suggestions from code review
haliliceylan Aug 16, 2021
bad9c48
update project toml
haliliceylan Aug 18, 2021
aa3611a
platform schema
haliliceylan Aug 18, 2021
047ef8b
Update text/0000-project-toml-converter.md
haliliceylan Aug 20, 2021
be67fa4
Update text/0000-project-toml-converter.md
haliliceylan Aug 20, 2021
58c1f28
Update text/0000-project-toml-converter.md
haliliceylan Aug 20, 2021
a053a83
last feedback
haliliceylan Aug 20, 2021
f5bddf3
little md fix
haliliceylan Aug 20, 2021
17487a4
add some values
haliliceylan Sep 14, 2021
06393bd
natalie suggestion
haliliceylan Sep 14, 2021
9b0c441
natalie suggestion
haliliceylan Sep 14, 2021
5c2075d
Update example
natalieparellano Oct 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update text/0000-project-toml-converter.md
Co-authored-by: Natalie Arellano <[email protected]>
Signed-off-by: Halil İbrahim ceylan <[email protected]>
haliliceylan and natalieparellano committed Aug 20, 2021
commit 077ef6ffa08d933ca358305c417ccb3db7e94a94
2 changes: 1 addition & 1 deletion text/0000-project-toml-converter.md
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ The idea is to ship a binary with the lifecycle that would be responsible for tr

- This feature has similarities with the "prepare" phase that has been discussed previously (see #555). But it is much smaller in scope. Potentially, the binary described in this RFC could eventually take on more responsibilities and look more like "prepare". But that is out of scope for this RFC.

- It is non-trivial for platform operators to upgrade support for different versions of project.toml. Project Descriptor is a file which describe behavior related to buildpacks. Platform operators need to give these behaviors according to developer app requests. So with this feature we are giving to developers the ability to use any version of project.toml knowing that the platform can always support it. At the same time we are giving to operators the convenience of only having to know about one schema at a time for project.toml.
- Project Descriptor (aka project.toml) is a file which describes behavior related to buildpacks. It is non-trivial for platform operators to upgrade support for different versions of project.toml. So with this feature we are giving to developers the ability to use any version of project.toml knowing that the platform can always support it. At the same time we are giving to operators the convenience of only having to know about one schema at a time for project.toml.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What operators are we talking about here? I have the sense that this should say platform implementers. If that is so then I have a predicament with this statement. Only a subset of the project.toml wouldn't be translated due to the fact that the spec allows for undefined keys/tables. It seems like platforms may very well still have to care about the initial input format to some degree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- What is the expected outcome?