Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Project Descriptor(project.toml) Converter #182
RFC: Project Descriptor(project.toml) Converter #182
Changes from 1 commit
8435e34
a6ab15c
429c841
4e93a27
93b2bd0
ca270f3
f1aa294
9002b56
b56261d
bde82fa
86e16cb
077ef6f
ee7363c
a1b591d
54acf19
bad9c48
aa3611a
047ef8b
be67fa4
58c1f28
a053a83
f5bddf3
17487a4
06393bd
9b0c441
5c2075d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What operators are we talking about here? I have the sense that this should say platform implementers. If that is so then I have a predicament with this statement. Only a subset of the
project.toml
wouldn't be translated due to the fact that the spec allows for undefined keys/tables. It seems like platforms may very well still have to care about the initial input format to some degree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jromero is this what you had in mind? https://github.com/buildpacks/rfcs/pull/182/files#diff-d6828a110979d409ba620d1b80593932c1cea332756b3cc7f7c14922dfc0b16aR132-R133