Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose the creation of best practices and guidelines #150

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

sambhav
Copy link
Member

@sambhav sambhav commented Mar 29, 2021

Signed-off-by: Sambhav Kothari [email protected]

Readable

@buildpacks/learning-maintainers @buildpacks/learning-contributors - please feel free to collaborate on the RFC and edit it :)

@sambhav sambhav requested a review from a team as a code owner March 29, 2021 19:05
Signed-off-by: Sambhav Kothari <[email protected]>
Signed-off-by: Sambhav Kothari <[email protected]>
@sambhav sambhav changed the title Propose the creation of a best practices and guidelines repository Propose the creation of a best practices and guidelines Mar 31, 2021
@sambhav sambhav changed the title Propose the creation of a best practices and guidelines Propose the creation of best practices and guidelines Mar 31, 2021
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this impetus is great. We had discussed having FAQs in the docs for various tools, and I think this can fit in that same general category of non-intuitive information we want to make sure is understood and can be found. Definitely a fan of this!


## Extend the spec

Have an extension to the spec that contains a list of `SHOULD`s and `MAY`s that capture the guidelines. This may however confuse users and may tie up something like the `spec` which is not geared towards end-users to `guidelines` which are supposed to be.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely against this idea - the spec is hard enough to read without asking people to read it even more for best practices, which should by their nature be easy to understand.

Comment on lines +106 to +107
- The exact set of guidelines that should be in the first cut of the repository
- Topics and details to cover
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if creating a discussion would be a good way of seeding the initial set of guidelines.

@jromero
Copy link
Member

jromero commented Apr 13, 2021

FCP based on majority sub-team binding votes. To be merged 4/20.

CC: @buildpacks/core-team

Copy link
Contributor

@yaelharel yaelharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea and I think @jromero's suggestion to start a discussion is a great way to move this forward.

@jromero jromero added the scope/team RFC scoped to a sub-team as opposed to the entire project. label Apr 14, 2021
jkutner added a commit that referenced this pull request Apr 26, 2021
[#150]

Signed-off-by: Joe Kutner <[email protected]>
@jkutner jkutner merged commit dc731da into buildpacks:main Apr 26, 2021
@sambhav sambhav deleted the guidelines branch April 26, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period issues-created/learning scope/team RFC scoped to a sub-team as opposed to the entire project. team/learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants