Skip to content

Commit

Permalink
Merge pull request #271 from buildpacks/AidanDelaney-patch-1
Browse files Browse the repository at this point in the history
Update directory in Build Config RFC
  • Loading branch information
sambhav authored Jan 22, 2023
2 parents cd09206 + 530ba8c commit 7fc2809
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions text/0109-build-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# Summary
[summary]: #summary

This RFC proposes an easy way to configure build images to allow specifying a `/cnb/config/env.build` CNB environment directory that allows updating the Buildpack `detect` and `build` environment based on the directory.
This RFC proposes an easy way to configure build images to allow specifying a `/cnb/build-config` CNB environment directory that allows updating the Buildpack `detect` and `build` environment based on the directory.


# Definitions
Expand Down Expand Up @@ -40,10 +40,10 @@ The environment variables may ideally also take precendence over any user provid
# What it is
[what-it-is]: #what-it-is

The RFC proposes the introduction of the following directory `/cnb/config/env.build` in build images. The directory follows the same convention as a `CNB environment directory`. The notable difference is that the environment variables sourced from this directory are applied **AFTER** processing the user-provided platform environment variables i.e. they should have the highest precedence. These variables should be available during both `detect` and `build` phases (and the `generate` phase in the future).
The RFC proposes the introduction of the following directory `/cnb/build-config/env` in build images. The directory follows the same convention as a `CNB environment directory`. The notable difference is that the environment variables sourced from this directory are applied **AFTER** processing the user-provided platform environment variables i.e. they should have the highest precedence. These variables should be available during both `detect` and `build` phases (and the `generate` phase in the future).


The operator can define this directory in the build image under `/cnb/config` or `CNB_CONFIG_DIR` if defined.
The operator can define this directory in the build image under `/cnb/build-config` or `CNB_BUILD_CONFIG_DIR` if defined.

# How it Works
[how-it-works]: #how-it-works
Expand Down Expand Up @@ -119,4 +119,4 @@ N/A
Addition of the definition of the above directory in the Platform specification i.e. -

- `CNB_BUILD_CONFIG_DIR`
- `/cnb/config/env.build`
- `/cnb/build-config/`

0 comments on commit 7fc2809

Please sign in to comment.