Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target validation when buildpack fails to declare field #1897

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix target validation when buildpack fails to declare field #1897

merged 1 commit into from
Sep 12, 2023

Conversation

natalieparellano
Copy link
Member

Optional fields are treated as wildcards when not specified

@natalieparellano
Fix target validation when buildpack fails to declare field
bc6c578 
Optional fields are treated as wildcards when not specified

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano added this to the 0.30.1 milestone Sep 11, 2023
@natalieparellano natalieparellano requested review from a team as code owners September 11, 2023 20:54
@github-actions github-actions bot modified the milestones: 0.30.1, 0.31.0 Sep 11, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 11, 2023
@natalieparellano natalieparellano mentioned this pull request Sep 11, 2023
Draft
jjbustamante
jjbustamante approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkutner jkutner modified the milestones: 0.31.0, 0.30.1 Sep 12, 2023
@jkutner jkutner merged commit 64de584 into main Sep 12, 2023
@jkutner jkutner deleted the fix/target-validation branch September 12, 2023 00:36
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbustamante jjbustamante jjbustamante approved these changes

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@natalieparellano @jkutner @jjbustamante