Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configuration to OCI Layout format when executing phases 1 by 1 #1882

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Adding configuration to OCI Layout format when executing phases 1 by 1 #1882

merged 2 commits into from
Sep 6, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Sep 4, 2023 •
edited
Loading

Summary

This PR adds the configuration for OCI Layout when an untrusted builder is used and pack call each phase one by one

Output

exporting to OCI Layout format using an untrusted builder actually configure the lifecycle in -layout mode

Before

Analyzer, Restorer and Exporter were not configured by pack

After

Pack includes the correct environment variables CNB_USE_LAYOUT=true and CNB_LAYOUT_DIR=/[layout repo] to enable the feature when calling the lifecycle

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1881

@github-actions github-actions bot added this to the 0.31.0 milestone Sep 4, 2023
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 4, 2023
@jjbustamante
adding some unit testing
cc49e29 
Signed-off-by: Juan Bustamante <[email protected]>
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 5, 2023
@github-actions github-actions bot modified the milestones: 0.30.1, 0.31.0 Sep 5, 2023
@jjbustamante jjbustamante marked this pull request as ready for review September 5, 2023 17:13
@jjbustamante jjbustamante requested review from a team as code owners September 5, 2023 17:13
@jkutner jkutner merged commit d225948 into main Sep 6, 2023
@jkutner jkutner deleted the bugfix/jjbustamante/issue-1881 branch September 6, 2023 13:06
@jjbustamante jjbustamante modified the milestones: 0.31.0, 0.30.1 Sep 12, 2023
@jjbustamante jjbustamante added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

Trying to export to OCI Layout format using an untrusted builder is not working, it exports to the daemon
2 participants
@jjbustamante @jkutner