Fix the rebasable flag logic in case of missing label #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Domenico Luciani <[email protected]>
github-actions
bot
added
type/enhancement
natalieparellano
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Thanks @dlion!!!
Maintainers, could we please pull this into 0.30.0?
Signed-off-by: Domenico Luciani <[email protected]>
dlion
force-pushed
the
1799-fix-rebasable-logic-and-test
branch
from
144db83 to
623c198
Compare
|
I think we could override Codecov in this case as multiple new tests were added! |
jkutner
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR I fixed the problem with the
rebasablelabel being set as afalseif theio.buildpacks.rebasabledidn't exist.Output
Before
After
Documentation
Related
Resolves #___