Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client.WithKeychain to use it during the lifecycle #1845

Closed
ernesto-jimenez opened this issue Jul 22, 2023 · 2 comments · Fixed by #1872
Closed

Fix client.WithKeychain to use it during the lifecycle #1845

ernesto-jimenez opened this issue Jul 22, 2023 · 2 comments · Fixed by #1872
Assignees
@natalieparellano
Labels
size/sm Small level of effort status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Milestone
0.31.0

Comments

@ernesto-jimenez
Copy link

Summary

When creating a client using WithKeychain, the keychain should be used in the lifecycle.

Right now, the lifecycle executor relies on the global authn.DefaultKeychain, rather than the one we set in the client.

Reproduction

Steps

Create a new authn.Keychain and inject it into the client.

Current behavior

The keychain is used at first, but the lifecycle still relies on authn.DefaultKeychain

Expected behavior

The client should inject it's keychain into a new field inside LifecycleOptions, and the executor should use the injected keychain rather than the global default.
@ernesto-jimenez ernesto-jimenez added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Jul 22, 2023
@natalieparellano natalieparellano added this to the 0.31.0 milestone Jul 24, 2023
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. size/sm Small level of effort and removed status/triage Issue or PR that requires contributor attention. labels Aug 14, 2023
@natalieparellano natalieparellano modified the milestones: 0.31.0, 0.30.1 Aug 22, 2023
@natalieparellano natalieparellano self-assigned this Aug 22, 2023
natalieparellano added a commit that referenced this issue Aug 23, 2023
@natalieparellano
Provides client keychain to lifecycle instead of the default keychain
21d1460 
Fixes #1845

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano mentioned this issue Aug 23, 2023
Merged
2 tasks
@natalieparellano
Copy link
Member

@ernesto-jimenez I opened #1872 to fix this - any chance you could test the branch out to verify?

@jjbustamante
Copy link
Member

Hi @ernesto-jimenez

We just released a RC pack version, it will be great if you can give it a try and confirm the issue was solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natalieparellano natalieparellano

Labels
size/sm Small level of effort status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Provides client keychain to lifecycle instead of the default keychain buildpacks/pack
3 participants
@ernesto-jimenez @jjbustamante @natalieparellano