Add GCP credential provider #887
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added in #540 but removed in #560. The GCP credential provider from github.com/vdemeester/k8s-pkg-credentialprovider/gcp would loop forever when the metadata server could not be reached (see kubernetes/kubernetes#86245). However it appears that the GGCR re-implementation in github.com/google/go-containerregistry/pkg/v1/google doesn't suffer from this problem, and therefore support for GCP might be safe to add back. Signed-off-by: Natalie Arellano <[email protected]>
| @@ -1,30 +1,31 @@ | |||
| module github.com/buildpacks/lifecycle | |||
|
|
|||
| require ( | |||
| github.com/BurntSushi/toml v1.1.0 | |||
| github.com/BurntSushi/toml v1.2.0 | |||
There was a problem hiding this comment.
In an effort to fix clashing dependencies, I updated them all, and this is breaking the build. Will downgrade...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added in #540 but removed in #560. The GCP credential provider from
github.com/vdemeester/k8s-pkg-credentialprovider/gcp would loop forever when the metadata
server could not be reached (see kubernetes/kubernetes#86245).
However it appears that the GGCR re-implementation in github.com/google/go-containerregistry/pkg/v1/google
doesn't suffer from this problem, and therefore support for GCP might be safe to add back.
See also:
I ran the experiment described here: #560 (comment) on this branch and didn't observe any issues. However it would be really nice to test this in a real environment.