Builder should warn if newer buildpacks write a bom in *.toml #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
Rename concrete implementation per review feedback Signed-off-by: Natalie Arellano <[email protected]>
|
Fixes #732 |
aemengo
approved these changes
Oct 12, 2021
| @@ -249,6 +249,9 @@ func (b *Descriptor) readOutputFiles(bpLayersDir, bpPlanPath string, bpPlanIn Pl | |||
| var launchTOML LaunchTOML | |||
| launchPath := filepath.Join(bpLayersDir, "launch.toml") | |||
|
|
|||
| bomValidator := NewBOMValidator(b.API, logger) | |||
|
|
|||
| var err error | |||
There was a problem hiding this comment.
Not sure if necessary. (var err error)
| } | ||
|
|
||
| func (h *v05To06BOMValidator) processBOM(buildpack GroupBuildpack, bom []BOMEntry) []BOMEntry { | ||
| return WithBuildpack(buildpack, bom) |
There was a problem hiding this comment.
I know this method wasn't created in this PR. But I'm surprised that it actually does anything
There was a problem hiding this comment.
This one's totally my bad. I just tested it out and it works fine.
| "github.com/buildpacks/lifecycle/api" | ||
| ) | ||
|
|
||
| type BOMValidator interface { |
There was a problem hiding this comment.
This doesn't look like it's used outside the package, so the public scope is slightly confusing.
|
Closing as this is covered in #749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Natalie Arellano [email protected]