Unmarshal empty lists, allow for adjustment-only build matrix #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it should be possible to define empty dimension lists, and then specify values for those dimensions via adjustments.
This pull request is currently
just a failing testjust some failing testssome tests by @pda and a solution written by @DrJosh9000 🙏🏼Currently, an empty list gets converted to
null
which gets rejected server-side as being an invalid value for a matrix dimension value.e.g. currently a pipeline like this:
is rejected with this error:
Because the
setup
is uploaded as"setup":{"color":null,"shape":null}
.