Canonicalise empty env/plugins/matrix to nil for sign/verify #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jcs
does not canonicalise{}
and[]
tonull
(or vice-versa).encoding/json
would obeyomitempty
as a directive in a struct field tag, but thecanonicalPayload
isn't encodingValues
as a struct - it's encoding amap[string]any
.Since there are a bunch of signatures floating about now, I made an educated guess that
null
would be the most common value for un-setenv
,plugins
, andmatrix
. But this may still break some signatures.