Enable process debug logging #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
reviewed
Dec 17, 2024
We currently don't pass the agentLogger object into Shell, so I can't easily use the existing logger. So we create one in using plain text mode
patrobinson
force-pushed
the
enable-process-debug-logging
branch
from
5332a97 to
3bdc5a6
Compare
DrJosh9000
approved these changes
Dec 18, 2024
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A long long time ago, in a galaxy far far away, the process debug logging was disabled
146c68e
We currently don't pass the agentLogger object into Shell, so I can't easily use the existing logger. So we create one in using plain text mode. Suggestions welcome on how to do that.
Context
Changes
Enable process logging in debug mode.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)