Schedule jobs in priority order #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
higher-priority-jobs-first
branch
from
699883e to
822be68
Compare
DrJosh9000
force-pushed
the
higher-priority-jobs-first
branch
from
822be68 to
2c634b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sort jobs by priority (descending) before sending them through to be scheduled. Highest priority jobs should be scheduled first, lowest priority jobs scheduled last.
Why
Fixes #445
Notes
The graphQL queries remove
scheduledAt(since it stopped being used with #427) and addspriority. My text editor also reformatted the GraphQL. The integration tests also hit a nil panic (these are sometimes flaky), so I have fixed the two instances of that particular path.