Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ignore missing with compressed #101

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

toote
Copy link
Contributor

@toote toote commented Jul 24, 2024

Handling of the ignore-missing option was not done correctly on downloads of compressed artifacts that may be missing. Refactored it and made it more obvious also preventing calls to relocation handling (and further processing) when not necessary.

Closes #99

@toote toote requested a review from a team as a code owner July 24, 2024 21:53
@toote toote added the bug label Jul 24, 2024
Copy link

@jeremybumsted jeremybumsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toote !! Looks good to me :)

Copy link
Contributor

@james2791 james2791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 👍

@pzeballos pzeballos merged commit 0f7e164 into master Jul 26, 2024
1 check passed
@pzeballos pzeballos deleted the toote_compressed_ignore branch July 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore-missing doesn't work with compressed & download configuration
4 participants