Bytestreams bugfixes #240
Merged
Bytestreams bugfixes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 21, 2019 12:10
Write resets required a new interface, close() was not sufficient to correctly handle a write request with a 0 offset with the intention of resetting.
ByteStreamService now uses the readBlob layer to interpret special unlimited 'limit' of 0.
Expand the ByteStringStreamSource to support committedSize and a completion future for close.
Present write query interface for progressive client implementations
An attempt to upload a previously completed blob will be handled immediately by the write listener, and must not attempt to write into its output stream.
The (renamed) ByteStringWriteReader now waits for a successful write completion in getData(), uses ByteString.Output, and try-with-resources. In the event of an empty operation stream for stdout/err, a null Write is used that completes immediately upon close. The Executor no longer interrupts the readers to preserve remote request safety - they are expected to close safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.