Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes installation with newer node versions (v7.10.0). Fixes an issue
with phantomjs when TMPDIR is not set. Adds missing yarn.lock files.
Since the package.json dependencies are the same for codeparameter,
console_view, nestedexample, waterfall_view and wsgi_dashboards, I
expect their yarn.lock also to be identical. This is achieved by running
yarn upgrade
once for each followed byyarn upgrade --prefer-offline
to get a deterministic run where the lock file does not change (due to
different dependency resolution?).
Tested by trying to install the frontend in a clean VM (with Arch Linux). Fails before this patch with at least the
console_view
package, after this patch installation completes as expected.I initially had some issues with deterministic orderings with yarn (yarnpkg/yarn#1168 (comment)), but resolved it with two steps:
Contributor Checklist: