Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: update guanlecoja to 0.8.3 #3274

Merged
merged 1 commit into from
May 27, 2017
Merged

Conversation

Lekensteyn
Copy link
Contributor

Fixes installation with newer node versions (v7.10.0). Fixes an issue
with phantomjs when TMPDIR is not set. Adds missing yarn.lock files.

Since the package.json dependencies are the same for codeparameter,
console_view, nestedexample, waterfall_view and wsgi_dashboards, I
expect their yarn.lock also to be identical. This is achieved by running
yarn upgrade once for each followed by yarn upgrade --prefer-offline
to get a deterministic run where the lock file does not change (due to
different dependency resolution?).


Tested by trying to install the frontend in a clean VM (with Arch Linux). Fails before this patch with at least the console_view package, after this patch installation completes as expected.

I initially had some issues with deterministic orderings with yarn (yarnpkg/yarn#1168 (comment)), but resolved it with two steps:

cd www
# First install dependencies (this was repeated at least 10 times, each time something different changed...)
for i in */;do (cd "$i" && yarn upgrade); done
# In the end this was tried and it gave a fixed ordering on repetitive runs.
for i in */;do (cd "$i" && yarn upgrade --prefer-offline); done

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

Fixes installation with newer node versions (v7.10.0). Fixes an issue
with phantomjs when TMPDIR is not set. Adds missing yarn.lock files.

Since the package.json dependencies are the same for codeparameter,
console_view, nestedexample, waterfall_view and wsgi_dashboards, I
expect their yarn.lock also to be identical. This is achieved by running
`yarn upgrade` once for each followed by `yarn upgrade --prefer-offline`
to get a deterministic run where the lock file does not change (due to
different dependency resolution?).
@codecov
Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #3274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3274   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         320      320           
  Lines       33293    33293           
=======================================
  Hits        29369    29369           
  Misses       3924     3924

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf24f3...e5a6476. Read the comment docs.

@tardyp tardyp merged commit 32565a5 into buildbot:master May 27, 2017
@tardyp
Copy link
Member

tardyp commented May 27, 2017

thanks!

@Lekensteyn Lekensteyn deleted the guanlecoja-update branch June 5, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants