Add tvOS specification #117
Conversation
Result of Integration 1Duration: 1 minute and 37 seconds |
| @@ -19,12 +19,14 @@ public class DevicePlatform : XcodeServerEntity { | |||
| case iOS_Simulator = "com.apple.platform.iphonesimulator" | |||
| case OSX = "com.apple.platform.macosx" | |||
| case watchOS = "com.apple.platform.watchos" | |||
| case watchOS_Simulator = "com.apple.platform.watchsimulator" | |||
| case watchOS_Simulator = "com.apple.platform.watchsimulator" // Why is it here? | |||
There was a problem hiding this comment.
Because simulators are different "platforms" - this is related to Xcode Server, which treats simulators and devices as different platforms.
On that note, is there a simulator platform for tvOS as well? I would expect there would be...
There was a problem hiding this comment.
Oh I see, you do have simulator type below. Can you also add the TV as tvOS_Simulator to this enum as well?
There was a problem hiding this comment.
So I don't understand why do we have duplicates for simulators?
|
Since each new platform is a bit fiddly, after you apply all your changes please try to create a Bot with the SDK and make sure the Bot finishes successfully. Thanks! |
|
@cojoj, sorry I completely missed that you pushed more commits. This looks great, have you actually tried creating Bots with the tvOS platform on Xcode Server and made sure they succeed? If so I'll merge it :) |
|
@czechboy0, I haven't tested it yet cause I'v found creating Bot some sort of a big hustle and I haven't got enough time for this, but will do it soon. BTW, I really think that amount of work we need to put into creating a Bot from scratch could be a PITA 😓 Calling integration is easy and so on, but creating a Bot is mostly a manual task and it requires a lot of input data... |
|
Even from the official docs it looks like a Bot Configuration is a PITA... 😓 |
Result of Integration 1Duration: 1 minute and 22 seconds |
|
With some help from #121 I was finally able to test that we can Also, This PR is ready to merge! 😉 (sorry for the delay, but too much on my mind ATM) |
Result of Integration 1Duration: 1 minute and 3 seconds |
|
Amazing work, @cojoj, thanks for taking the time to do this Sherlock work. I'll make a release with tvOS support in a couple of minutes. |
|
Actually, I can't 😆 @cojoj I can't install Xcode 7b3, so I tvOS is still an unrecognized platform on my release Xcode 7. Will have to wait a couple of days then, sorry :/ (Will try to install Xcode 7b2 tomorrow, b3 just doesn't work for me). |
|
Dependency: buildasaurs/BuildaUtils#7 |
@czechboy0 I'm wondering what more do we provide on
DeviceSpecification?Fixes #116.