Change the device sort to incorporate name and OS version. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original sorting algorithm placed devices before simulators and connected devices before disconnected devices. It did not account for device name and that made it difficult to find specific entries in a long list. This change places devices before simulators, then sorts by name and OS version. Connection status is no longer used to sort. Here are the first five items on our Xcode server under the old sort: - iPhone 4s 7.1 - iPhone 5 7.1 - iPhone 5s 7.1 - iPad 2 7.1 - iPad Retina 7.1 Here are the first five items on our Xcode server under the new sort: - iPad 2 7.1 - iPad 2 8.0 - iPad 2 8.1 - iPad 2 8.2 - iPad 2 8.3 This pattern makes it much easier to manually select the devices used by a build template.
Result of Integration 1Duration: 5 minutes and 12 seconds |
czechboy0
added a commit
that referenced
this pull request
Nov 4, 2015
…ingSystem Change the device sort to incorporate name and OS version.
|
Great, cheers @hallc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original sorting algorithm placed devices before simulators and
connected devices before disconnected devices. It did not account for
device name and that made it difficult to find specific entries in a
long list.
This change places devices before simulators, then sorts by name and
OS version. Connection status is no longer used to sort.
Here are the first five items on our Xcode server under the old sort:
Here are the first five items on our Xcode server under the new sort:
This pattern makes it much easier to manually select the devices used
by a build template.
Fixes #195