Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New status comment format (details of warnings, errors, test failures) #49

Open
3 of 6 tasks
czechboy0 opened this issue May 15, 2015 · 1 comment
Open
3 of 6 tasks

Comments

@czechboy0
Copy link
Member

It would be great to report failed tests, errors and warnings in detail in the GitHub comments already.

Test failures: we receive in the integration object.
Warnings/errors: we need to make an extra call to the integration's /issues endpoint.

  • required refactor + tests: Refactored comment creation (+ added tests) #184
  • add object that constructs the new comments with input data
  • pipe through the logic for asking for details of issues if build summary tells us that there was at least one error or warning)
  • only report the most serious problem (e.g. don't report warnings when a test failure or error occured)
  • split test (failure) information per device
  • add which devices the tests ran on

Currently blocked by

  • rdar://23142264 (Integrations endpoint doesn't return test result when asked for >1 integration)
@czechboy0 czechboy0 added this to the Gladiolus: Buildasaur 1.0 milestone Jul 13, 2015
@czechboy0
Copy link
Member Author

Mentioned in #84, it would be better if Buildasaur gave more detail about the devices that ran tests, e.g.

Result of integration 1
Integration took 25 minutes and 46 seconds.
All 0 tests passed, but please fix 567 warnings on iPhone 6 Plus iOS 8.4
1800 tests passed and 2 failed, but please fix 567 warnings on iPhone 4s iOS 7.1
1800 tests passed and 2 failed, but please fix 567 warnings on iPhone 4s iOS 8.4

@czechboy0 czechboy0 modified the milestone: Gladiolus: Buildasaur 1.0 Oct 13, 2015
@czechboy0 czechboy0 changed the title Report error description and failed test names in status comments New status comment format (details of warnings, errors, test failures) Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant