Buildasaur post multiple comments for the same integration

[valeriomazzeo]

[czechboy0]

• Does that happen on every integration?
• Can you reproduce this with a new Bot/PR?

(Now some stupid questions:)

• Are you possibly running two instances of Buildasaur (one downloaded, one from source? - has happened to me many times, that's why I'm asking)

[valeriomazzeo]

• it doesn't happen all the time
• yes but it's completely random
• 100% there is only one instance running

What I think it may be is that my integrations take as long as 20 minutes to finish.

Buildasaur timer is set to 15 seconds. Maybe the Xcode server API takes some time to close the build (or perhaps some responses are cached?) and if that happen in that 15 second span, Buildasaur then post a comment.

Ps: what happened to showing in the report the results from multiple simulators?

[czechboy0]

On the list, #49.

[valeriomazzeo]

Looking at the source code I think what it may happen is that if github is slow and the requests take anytime greater than the sync interval (default 15 seconds), there is a good chance that the post comment requests get stacked and queued because the status won't be updated.

I think the only solution would be to actually add some more check or limit the number of post comment requests per commit (PR) to 1.

In that case maybe post only the most recent one and cancel the previous one?

[czechboy0]

I've disabled all caching for this exact reason, but yes I've seen GitHub actually returning stale data for about 10 seconds after a change being made on the server.

The way it works now is that the Syncer checks what the current commit status is and what it's supposed to be. If they're different (and the transition is running -> finished), it updates the status and posts a comment. However, if, as you said, we sync again in 15 seconds and when we're checking for the status of the commit, and it returns the old value (running) again, instead of the actual value (finished), we'll do this again and post again.

At the moment, the only thing I can recommend is making the sync interval longer, let's say 30 seconds. To be honest, I have it set to short intervals mostly for testing + for projects where tests only take less than a minute. If you think about it, if your tests take 20minutes, delaying that by other 15 seconds won't make a difference in the grand scheme of things.

So yeah, make the interval longer and let me know if it keeps happening at 30 seconds. Right now there's no easy fix. However, long term, this should be fixed by #62, which will allow us to make many more API requests without them being counted towards our rate limit (so we'll be able to check whether this comment is already posted).

[czechboy0]

Ok, @valeriomazzeo, turns out El Cap changed the way NSURLSessionConfiguration behaves and the way I blocked URL request caching from happening stopped working - thus the repeated comments, because the requests were cached for about a minute by the system.

This is fixed by #174, which once again blocks caching from happening, thus fixing this issue of repeated comments. I tested this with 5sec sync interval and it only posted once.

I'll create a release with that now, so look out of 0.6.1, which will have this fixed. Thanks for reporting this!

[valeriomazzeo]

nice 👍