as per #130, changing the lttm barrier to be disabled by default for …

…new users

BuildaKit/HDGitHubXCBotSyncer.swift

@@ -53,7 +53,7 @@ public class HDGitHubXCBotSyncer : Syncer {
             self.project = project
             self.github = GitHubFactory.server(project.githubToken)
             self.xcodeServer = XcodeServerFactory.server(serverConfig)
-            self.waitForLttm = json.optionalBoolForKey("wait_for_lttm") ?? true
+            self.waitForLttm = json.optionalBoolForKey("wait_for_lttm") ?? false
             self.postStatusComments = json.optionalBoolForKey("post_status_comments") ?? true
             self.watchedBranchNames = json.optionalArrayForKey("watched_branches") as? [String] ?? []
             super.init(syncInterval: syncInterval)
@@ -63,7 +63,7 @@ public class HDGitHubXCBotSyncer : Syncer {
             self.github = nil
             self.xcodeServer = nil
             self.project = nil
-            self.waitForLttm = true
+            self.waitForLttm = false
             self.postStatusComments = true
             self.watchedBranchNames = []
             super.init(syncInterval: 0)

BuildaKitTests/SyncerTests.swift

@@ -34,7 +34,7 @@ class SyncerTests: XCTestCase {
         let githubServer = MockGitHubServer()
         let project = MockProject()
         let syncInterval = 15.0
-        let waitForLttm = true
+        let waitForLttm = false
         let postStatusComments = true
         let watchedBranchNames: [String] = []
 

Buildasaur/StatusSyncerViewController.swift

@@ -153,7 +153,7 @@ class StatusSyncerViewController: StatusViewController, SyncerDelegate {
             self.postStatusCommentsToggle.state = syncer.postStatusComments ? NSOnState : NSOffState
         } else {
             self.updateIntervalFromUIToValue(15) //default
-            self.lttmToggle.state = NSOnState //default is true
+            self.lttmToggle.state = NSOffState //default is false
             self.postStatusCommentsToggle.state = NSOnState //default is true
         }
     }
@@ -199,15 +199,15 @@ class StatusSyncerViewController: StatusViewController, SyncerDelegate {
 
     @IBAction func helpLttmButtonTapped(sender: AnyObject) {
 
-        let urlString = "https://github.com/czechboy0/Buildasaur/blob/master/README.md#the-lttm-barrier"
+        let urlString = "https://github.com/czechboy0/Buildasaur/blob/master/README.md#unlock-the-lttm-barrier"
         if let url = NSURL(string: urlString) {
             NSWorkspace.sharedWorkspace().openURL(url)
         }
     }
 
     @IBAction func helpPostStatusCommentsButtonTapped(sender: AnyObject) {
 
-        let urlString = "https://github.com/czechboy0/Buildasaur/blob/master/README.md#posting-status-comments"
+        let urlString = "https://github.com/czechboy0/Buildasaur/blob/master/README.md#envelope-posting-status-comments"
         if let url = NSURL(string: urlString) {
             NSWorkspace.sharedWorkspace().openURL(url)
         }

Podfile.lock

@@ -17,4 +17,4 @@ SPEC CHECKSUMS:
   ekgclient: 40f5d347e2ede450b3e50ac7c6bd84d96e7b84ad
   XcodeServerSDK: bdf7258e52589b49176fa909e360751f92cc5397
 
-COCOAPODS: 0.39.0.beta.4
+COCOAPODS: 0.38.2

README.md

@@ -81,7 +81,7 @@ You have multiple options of getting started with Buildasaur, from source code t
 ----------------
 The default workflow is as follows:
 - a Pull Request is created by the author, Builda creates a bot
-- if the "lttm" barrier (see below) is disabled, an integration is started immediately. if the "lttm" barrier is enabled, Builda waits until someone comments "lttm" in the Pull Request conversation (the "lttm" barrier is **enabled** by default, can be disabled in the UI)
+- if the "lttm" barrier (see below) is disabled, an integration is started immediately. if the "lttm" barrier is enabled, Builda waits until someone comments "lttm" in the Pull Request conversation (the "lttm" barrier is **disabled** by default, can be disabled in the UI)
 - an integration is performed on the PR's branch
 - result of the integration is reported back to GitHub by changing the status of the latest commit of the branch and posting a comment in the PR conversation (optional, enabled by default)
 - if any additional commits are pushed, another integration gets performed and reported back
@@ -91,7 +91,7 @@ The default workflow is as follows:
 :unlock: The "lttm" barrier
 ------------------
 - "Looks Testable To Me"
-- an optional extra step in the workflow (**enabled** by default)
+- an optional extra step in the workflow (**disabled** by default starting from version 0.5.0, previously was enabled by default in previous versions)
 - instead of integrating immediately after a PR is created, the reviewer first has a chance to look at the code and request any fixes of the code from the author
 - when the reviewer is happy with the code visually, she comments "lttm" in the PR and the bot is activated and performs an integration of the code
 - from that point on, if any additional commits are pushed, they get integrated as with the basic workflow