Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for headers and vcpkg manifest mode #27

Merged
merged 7 commits into from
May 31, 2021
Merged

Add support for headers and vcpkg manifest mode #27

merged 7 commits into from
May 31, 2021

Conversation

MoAlyousef
Copy link
Contributor

@MoAlyousef MoAlyousef commented May 28, 2021

The headers option creates a tree by itself instead of adding to sources, this allows IDE support without having to pass headers to target_sources, AFAIK this prevents internal headers from being treated as PUBLIC_HEADERS.

Closes #23

Copy link
Contributor

@mrexodia mrexodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested quite a few changes, but if you don't have time/don't feel like doing them I'll work on it in the next couple of days 🙂

src/gen.cpp Outdated Show resolved Hide resolved
src/gen.cpp Outdated Show resolved Hide resolved
src/gen.cpp Outdated Show resolved Hide resolved
src/gen.cpp Outdated Show resolved Hide resolved
src/gen.cpp Outdated Show resolved Hide resolved
src/gen.cpp Outdated Show resolved Hide resolved
@mrexodia mrexodia merged commit 5ad6134 into main May 31, 2021
@mrexodia mrexodia deleted the manifest branch May 31, 2021 13:30
@mrexodia
Copy link
Contributor

Awesome, thanks!

@mrexodia mrexodia mentioned this pull request Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replace PMM with vcpkg.json generation + bootstrapping
2 participants