Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check to make sure hash is valid hex #153

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Added check to make sure hash is valid hex #153

merged 3 commits into from
Nov 3, 2024

Conversation

deep9977
Copy link
Contributor

fixes #152

mrexodia
mrexodia requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@mrexodia mrexodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

src/project_parser.cpp Outdated Show resolved Hide resolved
include/project_parser.hpp Outdated Show resolved Hide resolved
@mrexodia mrexodia merged commit d02ee3e into build-cpp:main Nov 3, 2024
5 checks passed
@mrexodia
Copy link
Contributor

mrexodia commented Nov 3, 2024

I made some minor adjustments to the error messages and fixed the formatting, take a look if your interested.

@deep9977 deep9977 deleted the check-hash branch November 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrexodia mrexodia mrexodia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure the hash value is hex
2 participants
@deep9977 @mrexodia