Feature: history search#572 #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugy
requested changes
Sep 30, 2022
There was a problem hiding this comment.
Hi @gpsinghsandhu thanks for your PR! And sorry for super slow response :(
In general, the idea is good, but I would like to have it to be more Vue/reactive style, with having computed properties, instead of data+watch.
bugy
requested changes
Oct 5, 2022
bugy
requested changes
Oct 6, 2022
| }, | ||
|
|
||
| searchIconClickHandler() { | ||
| if (this.isClearSearchButton) { |
There was a problem hiding this comment.
I would suggest to check searchText instead
Also, if searchText is empty, probably we could focus the field, when the button is clicked
There was a problem hiding this comment.
Done.
I believe we should focus the field in any case (whether clearing or clicking search button).
Co-authored-by: Iaroslav Shepilov <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple implementation of search functionality in history. Search is implemented client-side. This currently searches only on 'user' and 'script' for the given search text. Suggestions are welcome.
Also fixed vue warning regarding mutating props. See commit - cdf8352
@bugy Need input on where to add this in documentation.
Note: I did not use the current 'SearchPanel' component, since it seemed very specific to the script search.
