Max chars input validation #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugy
reviewed
Dec 11, 2020
src/model/parameter_config.py
Outdated
| @@ -277,6 +279,9 @@ def validate_value(self, value, *, ignore_required=False): | |||
| return None | |||
|
|
|||
| if self.type == 'text': | |||
| if (not is_empty(self.max_chars)) and (len(value) > int(self.max_chars)): | |||
| return 'is greater than allowed char length (' \ | |||
There was a problem hiding this comment.
Could you change "greater" to "longer?
src/model/parameter_config.py
Outdated
| @@ -27,6 +27,7 @@ | |||
| 'type', | |||
| 'min', | |||
| 'max', | |||
| 'max_chars', | |||
There was a problem hiding this comment.
may be we could call it "max_length"? What do you think?
drehelis
force-pushed
the
max_chars
branch
2 times, most recently
from
61026aa to
9f40c57
Compare
|
Got a little confused and mistakenly pushed something else. Please have another look. Apologies for that. |
|
@bugy is there anything else required here? |
|
Oh, damn, i forgot about it, sorry :(
… @bugy <https://github.com/bugy> is there anything else required here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#375 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXPJLZPS4552AHRRZTHZ3SVRR5HANCNFSM4UVRZ6EQ>
.
|
bugy
approved these changes
Dec 19, 2020
bugy
added a commit
that referenced
this pull request
Dec 19, 2020
bugy
added a commit
that referenced
this pull request
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
max_charsconfig parameter to a text field.I sometime require limit user input to specific number of chars. I've been doing this until now with-in the executed script but I find it much useful this way.