Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape path delimiter in script name #304

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

miksir
Copy link

@miksir miksir commented Jun 2, 2020

If we will try to create script with path in name, like '/usr/bash' - the script config file will be created by absolute path /usr/bash.json

It's happens because slash wasnt escaped and path = os.path.join(self._script_configs_folder, _script_name_to_file_name(name)) will not use self._script_configs_folder if second parameter - absolute path

Copy link
Owner

@bugy bugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bugy bugy added this to the 1.16.0 milestone Jun 2, 2020
@bugy bugy merged commit 660595d into bugy:master Jun 2, 2020
@miksir miksir deleted the path_in_script_name_fix branch June 2, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants