Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth_info_ttl makes server to hang #425

Closed
bugy opened this issue Apr 5, 2021 · 1 comment
Closed

auth_info_ttl makes server to hang #425

bugy opened this issue Apr 5, 2021 · 1 comment
Labels
bug resolved
Milestone
1.17.0

Comments

@bugy
Copy link
Owner

bugy commented Apr 5, 2021

When auth_info_ttl option is enabled, time to time server hangs on user credentials refresh

Reported by @miksir:

it happens when state expire triggered and server going to update info to gitlab. When server hung there is no message "AbstractOauthAuthenticator.INFO] Loaded groups for" in logs
as I can see you saving state to gitlab_auth.json by timer now? may be there is some deadlock happens
@bugy bugy added the bug label Apr 5, 2021
@bugy bugy added this to the 1.17.0 milestone Apr 5, 2021
bugy added a commit that referenced this issue Apr 5, 2021
@bugy
#425 fixed wrong locks in coroutines, causing server to hang
5572cd4
@bugy bugy added the resolved label Apr 5, 2021
@bugy
Copy link
Owner Author

bugy commented Apr 5, 2021

Fixed, I was using a wrong lock (a normal one) in coroutines. Apparently, that was a bad idea
I didn't manage to reproduce the problem with proper coroutine locks

@bugy bugy closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
1 participant
@bugy