Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP auth username case sensitive #367

Closed
hamsterbacke opened this issue Nov 13, 2020 · 2 comments
Closed

LDAP auth username case sensitive #367

hamsterbacke opened this issue Nov 13, 2020 · 2 comments

Comments

@hamsterbacke
Copy link

I use the LDAP auth for login and allowed_users with the sAMAccountName.
The login is working successfull but sometimes the user can't see the scripts that it should be allowed to via allowed_users config.
I figured, that the case of the username on login is used for matching against allowed_users.
They logged in with "Bob" instead of bob and that prevents correct matching in allowd_users array.

As a quick fix I edited the file "auth/auth_ldap.py" and added .lower() in line 110:
username = request_handler.get_argument('username').lower()

I guess this case problem is affecting every login method.

@hamsterbacke hamsterbacke changed the title LDAP auth username case sensetive LDAP auth username case sensitive Nov 13, 2020
@bugy
Copy link
Owner

bugy commented Nov 13, 2020

True, thanks for reporting!

@bugy bugy added the bug label Nov 13, 2020
@bugy bugy added this to the 1.17.0 milestone Nov 13, 2020
@bugy
Copy link
Owner

bugy commented Nov 18, 2020

Fixed, now all authorization checks should be case-insensitive (for any auth provider)

@bugy bugy added the resolved label Nov 18, 2020
@bugy bugy closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants