Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: script panel size doesn't fit the page #234

Closed
bugy opened this issue Aug 24, 2019 · 1 comment
Closed

Safari: script panel size doesn't fit the page #234

bugy opened this issue Aug 24, 2019 · 1 comment

Comments

@bugy
Copy link
Owner

bugy commented Aug 24, 2019

If you select a script in Safari, the panel on the right (with description, parameters, buttons, and a log panel), then it's not adjusted to the screen height.
If the content is small, then the panel height is too small also.
If the content is large, then the panel grows outside of the page (instead log panel should get a scroll)

@bugy bugy added the bug label Aug 24, 2019
@bugy
Copy link
Owner Author

bugy commented Aug 24, 2019

The problem happens because of height:100%, display:flex and flex: 1 1 auto.
There was a bug in CSS flexbox spec: w3c/csswg-drafts#1679 and both Safari and Chrome implemented the spec with this bug.
The bug (short version, in my understanding) is that flex-basis: auto should always be indefinite, so height:100% shouldn't be resolvable.

Since then, the CSS spec updated and Chrome updated their implementation. However Safari still implements the old version of the spec, that's why flex-basis: auto and height: 100% don't work there

bugy added a commit that referenced this issue Aug 24, 2019
@bugy bugy added the resolved label Aug 24, 2019
@bugy bugy added this to the 1.15.0 milestone Aug 24, 2019
@bugy bugy closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant