Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters - Type List - Allow editable / Allow custom value #225

Closed
csphoenix1 opened this issue Jul 31, 2019 · 7 comments
Closed

Parameters - Type List - Allow editable / Allow custom value #225

csphoenix1 opened this issue Jul 31, 2019 · 7 comments

Comments

@csphoenix1
Copy link
Contributor

It could be useful to allow make type list parameter as editable.

In case we have set a list of predefined values in the JSON file, if the user want to change some things in the value of the list element it have selected, there is no option to edit the value or to add a custom value for the user.
In other words, the users have no other choice than the element in the list.

Is it possible to add 2 parameters like for example :

  • allow_custom_value_in_list_type
  • allow_editable_element_in_list_type

Thank you :)

@csphoenix1 csphoenix1 changed the title Parameters - Type List - Make it editable Parameters - Type List - Allow editable / Allow custom value Jul 31, 2019
@bugy bugy added the feature label Aug 17, 2019
@bugy
Copy link
Owner

bugy commented Aug 17, 2019

Hi @csphoenix1 are these 2 parameters just proposed names for the same feature? Or are they different?

@csphoenix1
Copy link
Contributor Author

Hi @bugy,

If I remember, this request was for 2 editables parameters.
But after re-reading my request today, I understand the 2 parameters in my examples was the same thing because custom/editable is the same.

So, in conclusion, it's for the same feature :)

@bugy bugy added this to the 1.17.0 milestone Nov 18, 2020
bugy added a commit that referenced this issue Mar 25, 2021
@bugy
Copy link
Owner

bugy commented Mar 25, 2021

Done, new type is called editable_list, user can either select a value from the list or type his own.
I had to use a different UI component for it, than previous combobox for 2 reasons:

  1. the UI library I'm using doesn't support editable combobox, so I would have to write quite some changes to make it work
  2. even after I did it, the interaction with custom values was not very convenient. I find the behaviour of the used component cleaner (with a search and highlighting)

@bugy bugy added the resolved label Mar 25, 2021
@yosefy
Copy link

yosefy commented Aug 4, 2021

setting default value is not working in editable_list.
also acts strange
i think if default value is part of one of the values on the list (preconfigured)
it will list them
only

@bugy
Copy link
Owner

bugy commented Aug 4, 2021

Hi @yosefy, thanks for reporting, I'll take a look.
Does everything else work good there?

@yosefy
Copy link

yosefy commented Aug 5, 2021

yes if i don't set default all works perfect

@bugy
Copy link
Owner

bugy commented Sep 14, 2021

I totally forgot this ticket and checked it only now. I'm really sorry for the delay

Unfortunately, the current behavior is kind of expected. The component is performing automatic filtering when you write a value (doesn't matter if it's a default one, or you just input it from a keyboard).
This is not ideal and might be confusing, but for the current version I would keep it

@bugy bugy closed this as completed Sep 14, 2021
@bugy bugy reopened this Sep 14, 2021
@bugy bugy closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants