Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't download output files with cyrillic names #195

Closed
magonov opened this issue Mar 11, 2019 · 1 comment
Closed

Couldn't download output files with cyrillic names #195

magonov opened this issue Mar 11, 2019 · 1 comment
Milestone

Comments

@magonov
Copy link

magonov commented Mar 11, 2019

I've just adopted nice music downloader script to run with Script Server:
https://github.com/yask123/Instant-Music-Downloader
It works just fine except for the songs with cyrillic names. When trying to download such file, browser gives 404 error (file not found).

@magonov magonov changed the title Couldn't download output files with cyrillic name Couldn't download output files with cyrillic names Mar 11, 2019
@bugy bugy added the bug label Mar 18, 2019
bugy added a commit that referenced this issue Mar 20, 2019
@bugy bugy added this to the 1.14 milestone Mar 20, 2019
@bugy bugy added the resolved label Mar 20, 2019
@bugy
Copy link
Owner

bugy commented Mar 20, 2019

Thanks for reporting, I committed the fix, it will go into the next release.

Quite weird, that I didn't notice it before. The failing code is there for 2 years already

@bugy bugy closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants