Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to upload large files #184

Closed
bugy opened this issue Feb 20, 2019 · 4 comments
Closed

Add possibility to upload large files #184

bugy opened this issue Feb 20, 2019 · 4 comments

Comments

@bugy
Copy link
Owner

bugy commented Feb 20, 2019

At the moment, when uploading a large file (~100Mb), web server fails with

Malformed HTTP message from ....: Content-Length too long

It should be possible to allow larger files, probably with setting max file size manually in Script server configuration.

@bugy bugy added the feature label Feb 20, 2019
bugy added a commit that referenced this issue Mar 2, 2019
…iles efficiently + added config for max http request size
@bugy
Copy link
Owner Author

bugy commented Mar 2, 2019

Done. Now max request size can be configured in server config (conf/conf.json), with max_request_size parameter (in megabytes).
By default the current limit is 10Mb

Also implemented streamed reading of uploaded_files, i.e. bytes are written to disk as soon as they come without buffering in memory. Tested on 6gb file, memory consumption stayed below 25Mb during the upload.
This can cause regression issues with parsing input parameters of the scripts

@bugy bugy added the resolved label Mar 2, 2019
@bugy bugy added this to the 1.14 milestone Mar 2, 2019
bugy added a commit that referenced this issue Mar 2, 2019
@magonov
Copy link

magonov commented Mar 3, 2019

What a useful feature!
Thank you so much!

@bugy bugy closed this as completed Mar 20, 2019
@dridk
Copy link

dridk commented Dec 9, 2020

could you add this new parameter into the documentation ?

@bugy
Copy link
Owner Author

bugy commented Dec 9, 2020

Oops, thanks for noticing, @dridk!
Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants