-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release source and support Unity v6 #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build size impact
Generated by 🚫 Danger |
richardelms
changed the title
Plat 13006 ship source
release source and support Unity v6
Nov 7, 2024
tomlongridge
reviewed
Nov 8, 2024
tomlongridge
approved these changes
Nov 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
BugsnagUnityWebRequest
to remove deprecation warnings and support newPostWwwForm
methods introduced in Unity 2022.2Design
Releasing pre compiled DLLs meant that our development cycle was slow as you would have to package the SDK after every change.
It also meant we could not take advantage of unity provided compiler flags to support multiple versions,
#if UNITY_2022_2_OR_NEWER
for example.With this change to shipping source files, development time and build time is reduced to a fraction of what it was in the previous setup.
Another benefit is that we can simply open up the development project in new versions of Unity and solve issues that arise on the spot using the above mentioned flags.
In theory, using this approach means that we never have to drop support for a Unity version again, obviously this would not be good for E2E CI setup, but it's a comforting thought 😄
Other benefits to this PR include:
.UnityPackage
andUPM Package
build process.Changeset
Rakefile
as dotnet compilation is no longer required.Testing
Unit tests passing and full CI run passing.