Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing issues when Bugsnag started after the focus event #825

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix timing issues when Bugsnag started after the focus event #825

merged 2 commits into from
Jul 9, 2024

Conversation

JamesLindsay0
Copy link
Contributor

Goal

Fix issues where Bugsnag is started after the focus event is received (so the foreground timer was never started).

Changeset

  • Start the foreground stopwatch automatically on startup.
  • Use the Duration rather than the ForegroundDuration to determine if the app has launched as it takes account of the time before Bugsnag was started.

Supersedes #821.

@richardelms richardelms self-requested a review July 8, 2024 10:59
richardelms
richardelms approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@richardelms richardelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please don't merge yet as this is technically a breaking change.

@richardelms richardelms merged commit d03d70f into next Jul 9, 2024
12 checks passed
@richardelms richardelms deleted the fix-started-after-focus branch July 9, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardelms richardelms richardelms approved these changes

Assignees

@JamesLindsay0 JamesLindsay0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesLindsay0 @richardelms