Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-12181 make callback collections thread safe #810

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

richardelms
Copy link
Contributor

Goal

make all callback collections within the config thread safe

Testing

Added unit tests

@richardelms richardelms self-assigned this Jun 6, 2024
@richardelms richardelms requested a review from tomlongridge June 6, 2024 08:11
@richardelms richardelms marked this pull request as ready for review June 6, 2024 08:11
@bugsnagbot
Copy link
Collaborator

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2442.63
IL2CPP IPA 1512.9

Generated by 🚫 Danger

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: With a small formatting suggestion

tests/BugsnagUnity.Tests/ConfigurationTests.cs Outdated Show resolved Hide resolved
@richardelms richardelms merged commit dab50cb into next Jun 6, 2024
13 checks passed
@richardelms richardelms deleted the 12181-makeCallbacksThreadSafe branch June 6, 2024 09:41
@richardelms richardelms mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants