-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(persistence): implement persisting sessions when delivery fails #509
Conversation
# Conflicts: # src/BugsnagUnity/Client.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was persisting sessions prior to sending a deliberate design decision?
We not too long ago changed the Cocoa notifier to only persist sessions if sending failed, in order to reduce disk activity...
Good thinking, i changed to so that it now has a list of pending sessions saved in memory, and it only writes them to disk if they fail to send 👍 |
Goal
implement persisting sessions when delivery fails
Design
The flow is as follows.
1: When a session is recorded it gets added to a list of pending session payloads in memory
2: If the session is sent successfully then the pending session is removed
3: If the sessio fails to send it is written to disk, then on next startup or when the app comes back into focus we try and send it again
Changeset
Testing
Added CI tests for Windows and WebGL