Support Angular 19 #2278
Merged
Support Angular 19 #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-12867/angular-main-package-entry
branch
from
caeed8a to
89bf476
Compare
gingerbenw
changed the title
gingerbenw
force-pushed
the
PLAT-12867/angular-main-package-entry
branch
from
26424d3 to
d36884e
Compare
gingerbenw
force-pushed
the
PLAT-12867/angular-main-package-entry
branch
from
d36884e to
76f8949
Compare
djskinner
reviewed
Jan 10, 2025
Comment on lines
37
to
38
| // ErrorHandler.prototype.handleError.call(this, error) | ||
| console.error(error) |
There was a problem hiding this comment.
is this meant to be like this?
There was a problem hiding this comment.
oops, not the commented out code - but yes! this is the default behaviour of the angular error handler which we're replicating. calling the prototype to do this can cause a mismatch between the compiled code and the angular version. I'll add a comment covering this.
gingerbenw
force-pushed
the
PLAT-12867/angular-main-package-entry
branch
2 times, most recently
from
bc48859 to
7b9d7d9
Compare
djskinner
approved these changes
Jan 16, 2025
yousif-bugsnag
approved these changes
Jan 16, 2025
hannah-smartbear
pushed a commit
that referenced
this pull request
Jan 31, 2025
* chore(@bugnsnag/plugin-angular): ⬆️ update angular dependency to v17 * test: ✅ create angular 12 test fixture * test: ✅ remove extra package from package json * test: 🔥 remove unused fixture * build plugin using ng-packager * refactor: ♻️ refactor plugin-angular * set openssl-legacy-provider * update typescript version * update build directory * test: remove ErrorHandler.prototype.handleError.call * reinstate handleError prototype call * build angular 12 fixture with ivy * add console error to replicate default angular error handler behavior * change build to browser-esbuild * docs: 📝 update CHANGELOG.md * docs: 📝 explain console error left in angular plugin * chore: 👷 update build script to remove dist * fixup package lock * refactor: ♻️ remove angular workspace directory * add directory to publishConfig * run npm build during prepack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR fixes a number of bugs and updates the current level of Angular support, using the latest build system
Changeset
publishConfig.directoryto ensure only thedistdirectory is published for updated angular packageprepackscript to re-build and ensure correct version number is used for published packageTesting
browser-esbuildbuilder