Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11399] Bugsnag CLI iOS x React Native CLI #2073

Merged
merged 102 commits into from
May 1, 2024

Conversation

joshedney
Copy link
Contributor

@joshedney joshedney commented Jan 24, 2024

Goal

Update the React Native CLI to install BugSnag CLI instead of the Source Maps package for the iOS/Xcode Integration.

If we detect that RN version is >= 0.69.0 we will set up the .xcode.env file to output the file source map files to our happy path ios/build/sourcemaps/.

If we detect that the RN version is < 0.69.0 we set up the extra arguments within the xcode build phase due to it not supporting the .xcode.env file.

Both options ensure the source map file is located where our bugsnag-cli expects it.

Add all 5 upload tasks and the create build task to the package.json

  • bugsnag:create-build - Creates a new build
  • bugsnag:upload-android - Uploads Android source maps
  • bugsnag:upload-rn-android - Uploads React Native Android source maps
  • bugsnag:upload-dsym - Uploads iOS dSYMs
  • bugsnag:upload-rn-ios - Uploads React Native iOS source maps
  • bugsnag:upload - Runs all of the above tasks

Changeset

Update the AutomateSymbolicationCommand.ts to install the BugSnag CLI package for the iOS integration.

Testing

Covered by CI

Copy link

github-actions bot commented Jan 24, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.80 kB 13.43 kB
After 43.80 kB 13.43 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against a1def2d

@joshedney joshedney requested a review from tomlongridge April 22, 2024 08:37
@joshedney joshedney merged commit fc65143 into next May 1, 2024
55 checks passed
@joshedney joshedney deleted the je/plat-11399-bugsnag-cli-rn-ios branch May 1, 2024 08:50
@gingerbenw gingerbenw mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants