-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-11399] Bugsnag CLI iOS x React Native CLI #2073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Longridge <[email protected]>
tomlongridge
approved these changes
Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update the React Native CLI to install BugSnag CLI instead of the Source Maps package for the iOS/Xcode Integration.
If we detect that RN version is >= 0.69.0 we will set up the
.xcode.env
file to output the file source map files to our happy pathios/build/sourcemaps/
.If we detect that the RN version is < 0.69.0 we set up the extra arguments within the xcode build phase due to it not supporting the
.xcode.env
file.Both options ensure the source map file is located where our
bugsnag-cli
expects it.Add all 5 upload tasks and the create build task to the
package.json
Changeset
Update the
AutomateSymbolicationCommand.ts
to install the BugSnag CLI package for the iOS integration.Testing
Covered by CI