Allow notifier time to synch state with native layer #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
approved these changes
Dec 4, 2020
fractalwrench
approved these changes
Dec 4, 2020
twometresteve
force-pushed
the
tms/code-bundle-id-flake
branch
from
b7033bd to
4e95c4c
Compare
Not specifically, but if it's a race condition that we're talking about I can believe that the plumbing and mechanics of rn0.63 simply take more time that 0.60. Sadly though the story doesn't seem to be over on this PR, as it's flagged up a persistent failure in at least one other scenario, which wasn't included in my trials. Very surprising. |
twometresteve
force-pushed
the
tms/code-bundle-id-flake
branch
from
8881b36 to
434bb3b
Compare
nickdowell
approved these changes
Dec 7, 2020
fractalwrench
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Attempts to resolve a persistent flaking test that requires JS layer state to be synched with the native layer.
Testing
The scenario in question was flaking for me 3/5 before the change. With it in it has passed 10/10 times.