Merge pull request #1428 from bugsnag/nickdowell/bugsnag-cocoa-v6.9.4

deps(react-native): Update bugsnag-cocoa to v6.9.4

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## TBD
+
+### Changed
+
+- (react-native): Update bugsnag-cocoa to v6.9.4
+  - Improve performance of `notify()`. [bugsnag-cocoa#1102](https://github.com/bugsnag/bugsnag-cocoa/pull/1102) [bugsnag-cocoa#1104](https://github.com/bugsnag/bugsnag-cocoa/pull/1104) [bugsnag-cocoa#1105](https://github.com/bugsnag/bugsnag-cocoa/pull/1105)
+  - Fix a crash in `-[BugsnagApp deserializeFromJson:]` if main Mach-O image could not be identified, and improve reliability of identification. [bugsnag-cocoa#1097](https://github.com/bugsnag/bugsnag-cocoa/issues/1097) [bugsnag-cocoa#1101](https://github.com/bugsnag/bugsnag-cocoa/pull/1101)
+  - Remove need for `-ObjC` linker flag if linking Bugsnag as a static library. [bugsnag-cocoa#1098](https://github.com/bugsnag/bugsnag-cocoa/pull/1098)
+
 ## 7.10.1 (2021-05-25)
 
 ### Changed

packages/react-native/ios/.bugsnag-cocoa-version

@@ -1 +1 @@
-b83847c74669f64a9afc0e7e7ade595b620c09e8
+ede9f5b207fb3ad2fd12464b9495795454b3745c

packages/react-native/ios/BugsnagReactNative/BugsnagEventDeserializer.m

@@ -59,6 +59,7 @@ - (BugsnagEvent *)deserializeEvent:(NSDictionary *)payload {
             NSMutableArray<NSDictionary *> *mixedStack = [NSMutableArray array];
             for (BugsnagStackframe *frame in [BugsnagStackframe stackframesWithCallStackSymbols:nativeStack]) {
                 frame.type = BugsnagStackframeTypeCocoa;
+                [frame symbolicateIfNeeded];
                 [mixedStack addObject:[frame toDictionary]];
             }
             [mixedStack addObjectsFromArray:stacktrace];

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag.podspec.json

@@ -1,6 +1,6 @@
 {
   "name": "Bugsnag",
-  "version": "6.9.2",
+  "version": "6.9.4",
   "summary": "The Bugsnag crash reporting framework for Apple platforms.",
   "homepage": "https://bugsnag.com",
   "license": "MIT",
@@ -9,7 +9,7 @@
   },
   "source": {
     "git": "https://github.com/bugsnag/bugsnag-cocoa.git",
-    "tag": "v6.9.2"
+    "tag": "v6.9.4"
   },
   "frameworks": [
     "Foundation",

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/BugsnagSessionTracker.h

@@ -72,17 +72,10 @@ extern NSString *const BSGSessionUpdateNotification;
 
 /**
  Handle some variation of Bugsnag.notify() being called.
- Increases the number of handled errors recorded for the current session, if
+ Increments the number of handled or unhandled errors recorded for the current session, if
  a session exists.
  */
-- (void)handleHandledErrorEvent;
-
-/**
- Handled Bugsnag.notify() being called with an event with unhandled = YES.
- Increases the number of unhandled errors recorded for the current session, if
- a session exists.
- */
-- (void)handleUnhandledErrorEvent;
+- (void)incrementEventCountUnhandled:(BOOL)unhandled;
 
 /**
  * Retrieves the running session, or nil if the session is stopped or has not yet been started/resumed.

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/BugsnagSessionTracker.m

@@ -202,31 +202,19 @@ - (void)handleAppForegroundEvent {
     self.backgroundStartTime = nil;
 }
 
-- (void)handleHandledErrorEvent {
+- (void)incrementEventCountUnhandled:(BOOL)unhandled {
     BugsnagSession *session = [self runningSession];
 
     if (session == nil) {
         return;
     }
 
     @synchronized (session) {
-        session.handledCount++;
-        if (self.callback) {
-            self.callback(session);
+        if (unhandled) {
+            session.unhandledCount++;
+        } else {
+            session.handledCount++;
         }
-        [self postUpdateNotice];
-    }
-}
-
-- (void)handleUnhandledErrorEvent {
-    BugsnagSession *session = [self runningSession];
-
-    if (session == nil) {
-        return;
-    }
-
-    @synchronized (session) {
-        session.unhandledCount++;
         if (self.callback) {
             self.callback(session);
         }

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/BugsnagSystemState.h

@@ -34,8 +34,6 @@ NS_ASSUME_NONNULL_BEGIN
 - (instancetype)init NS_UNAVAILABLE;
 - (instancetype)initWithConfiguration:(BugsnagConfiguration *)config;
 
-- (void)recordAppUUID;
-
 - (void)setCodeBundleID:(NSString*)codeBundleID;
 
 @property (nonatomic) NSUInteger consecutiveLaunchCrashes;

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/BugsnagSystemState.m

@@ -97,6 +97,7 @@ id blankIfNil(id value) {
     app[BSGKeyReleaseStage] = config.releaseStage;
     app[BSGKeyVersion] = blankIfNil(systemInfo[@BSG_KSSystemField_BundleShortVersion]);
     app[BSGKeyBundleVersion] = blankIfNil(systemInfo[@BSG_KSSystemField_BundleVersion]);
+    app[BSGKeyMachoUUID] = [BSG_KSSystemInfo appUUID];
     app[@"inForeground"] = @(isInForeground);
     app[@"isActive"] = @(isActive);
 #if BSG_PLATFORM_TVOS
@@ -237,11 +238,6 @@ - (void)sessionUpdateNotification:(NSNotification *)notification {
     }];
 }
 
-- (void)recordAppUUID {
-    // [BSG_KSSystemInfo appUUID] returns nil until we have called _dyld_register_func_for_add_image()
-    [self setValue:[BSG_KSSystemInfo appUUID] forAppKey:BSGKeyMachoUUID];
-}
-
 - (void)setCodeBundleID:(NSString*)codeBundleID {
     [self setValue:codeBundleID forAppKey:BSGKeyCodeBundleId];
 }

packages/react-native/ios/vendor/bugsnag-cocoa/Bugsnag/Client/BugsnagClient+Private.h

@@ -35,6 +35,10 @@ NS_ASSUME_NONNULL_BEGIN
 
 @property (nullable, nonatomic) BugsnagEvent *appHangEvent;
 
+/// Alters whether error detection should be enabled or not after Bugsnag has been initialized.
+/// Intended for internal use only by Unity.
+@property (nonatomic) BOOL autoNotify;
+
 @property (nullable, retain, nonatomic) BugsnagBreadcrumbs *breadcrumbs;
 
 @property (nullable, nonatomic) NSString *codeBundleId;