Merge pull request #1188 from bugsnag/release/v7.5.4

Release v7.5.4
bugsnag · Dec 10, 2020 · 2a413c0 · 2a413c0
2 parents 8720e32 + c80f629
commit 2a413c0
Show file tree

Hide file tree

Showing 154 changed files with 1,587 additions and 1,082 deletions.
diff --git a/.buildkite/expo-pipeline.yml b/.buildkite/expo-pipeline.yml
@@ -109,7 +109,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':runner: expo iOS 12'
@@ -133,7 +133,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - block: "Trigger full test suite"
@@ -155,7 +155,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
     soft_fail:
       - exit_status: "*"
@@ -177,7 +177,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':runner: expo Android 6'
@@ -197,7 +197,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':runner: expo Android 5'
@@ -217,7 +217,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - --retry=2
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':runner: expo iOS 11'
@@ -239,7 +239,7 @@ steps:
           - --fail-fast
           - --retry=2
           - --resilient
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':runner: expo iOS 10'
@@ -260,5 +260,5 @@ steps:
           - --fail-fast
           - --retry=2
           - --resilient
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
diff --git a/.buildkite/react-native-pipeline.yml b/.buildkite/react-native-pipeline.yml
@@ -223,7 +223,7 @@ steps:
         - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':ios: RN 0.60 iOS 12 end-to-end tests'
@@ -246,7 +246,7 @@ steps:
         - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':android: RN 0.63 Android 9 end-to-end tests'
@@ -268,7 +268,7 @@ steps:
         - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':ios: RN 0.63 iOS 12 end-to-end tests'
@@ -291,7 +291,7 @@ steps:
         - --fail-fast
     env:
       SKIP_NAVIGATION_SCENARIOS: "true"
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':android: react-navigation 0.60 Android 9 end-to-end tests'
@@ -312,7 +312,7 @@ steps:
         - --access-key=$BROWSER_STACK_ACCESS_KEY
         - --fail-fast
         - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   # See: PLAT-5173
@@ -336,7 +336,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':android: react-navigation 0.63 Android 9 end-to-end tests'
@@ -357,7 +357,7 @@ steps:
         - --access-key=$BROWSER_STACK_ACCESS_KEY
         - --fail-fast
         - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   # See: PLAT-5173
@@ -381,7 +381,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':android: react-native-navigation 0.60 Android 9 end-to-end tests'
@@ -402,7 +402,7 @@ steps:
         - --access-key=$BROWSER_STACK_ACCESS_KEY
         - --fail-fast
         - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   # See: PLAT-5173
@@ -426,7 +426,7 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   - label: ':android: react-native-navigation 0.63 Android 9 end-to-end tests'
@@ -447,7 +447,7 @@ steps:
         - --access-key=$BROWSER_STACK_ACCESS_KEY
         - --fail-fast
         - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
 
   # See: PLAT-5173
@@ -471,5 +471,5 @@ steps:
           - --access-key=$BROWSER_STACK_ACCESS_KEY
           - --fail-fast
           - features/navigation.feature
-    concurrency: 10
+    concurrency: 9
     concurrency_group: 'browserstack-app'
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,20 @@
 # Changelog
 
+## v7.5.4 (2020-12-10)
+
+### Changed
+
+- (expo): Add integrity header to verify Error and Session API payloads have not changed. [#1172](https://github.com/bugsnag/bugsnag-js/pull/1172)
+- (react-native): Update bugsnag-android to v5.3.1
+  - Add integrity header to verify Error and Session API payloads have not changed. [bugsnag-android#978](https://github.com/bugsnag/bugsnag-android/pull/978)
+  - Prevent potential SHA-1 hash mismatch in Bugsnag-Integrity header [#1028](https://github.com/bugsnag/bugsnag-android/pull/1028)
+- (react-native): Update bugsnag-cocoa to v6.3.0
+  - Add integrity header to verify Error and Session API payloads have not changed. [bugsnag-cocoa#881](https://github.com/bugsnag/bugsnag-cocoa/pull/881)
+  - Out Of Memory errors now include more information, including custom metadata and user information. [bugsnag-cocoa#915](https://github.com/bugsnag/bugsnag-cocoa/pull/915) [bugsnag-cocoa#908](https://github.com/bugsnag/bugsnag-cocoa/pull/908)
+  - Fixed incorrect app version reported when sending crash reports from older versions of Bugsnag (before 6.2.3) [bugsnag-cocoa#911](https://github.com/bugsnag/bugsnag-cocoa/pull/911)
+  - Fixed a rare crash in -[BugsnagClient computeDidCrashLastLaunch] [bugsnag-cocoa#917](https://github.com/bugsnag/bugsnag-cocoa/pull/917)
+- (core) The `event.unhandled` flag can now be changed in callbacks [#1148](https://github.com/bugsnag/bugsnag-js/pull/1148)
+
 ## v7.5.3 (2020-12-01)
 
 - (react-native): Update bugsnag-cocoa to v6.2.5

diff --git a/TESTING.md b/TESTING.md
@@ -197,7 +197,7 @@ npm run test:build-react-native-ios
 
 Fnd Android:
 ```shell script
-npm run test:build-react-native-ios
+npm run test:build-react-native-android
 ```
 These will build a `.ipa` or `.apk` file respectively and copy into `./build`.
 

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -32,7 +32,6 @@ services:
         - BUILDKITE_BUILD_NUMBER
     command: --fail-fast --retry 2
     environment:
-      VERBOSE:
       DEBUG:
       BROWSER: "${BROWSER:-chrome_61}"
       BROWSER_STACK_USERNAME:
@@ -55,7 +54,6 @@ services:
       NODE_VERSION: "${NODE_VERSION:-10}"
       COMPOSE_PROJECT_NAME: "node${NODE_VERSION:-10}"
       NETWORK_NAME: "${BUILDKITE_JOB_ID:-js-maze-runner}"
-      VERBOSE:
       DEBUG:
     networks:
       default:
@@ -71,7 +69,6 @@ services:
       args:
         - BUILDKITE_BUILD_NUMBER
     environment:
-      VERBOSE:
       DEBUG:
     networks:
       default:
@@ -98,7 +95,6 @@ services:
       context: .
       dockerfile: dockerfiles/Dockerfile.expo-android-builder
     environment:
-      VERBOSE:
       DEBUG:
       EXPO_USERNAME:
       EXPO_PASSWORD:
@@ -123,7 +119,6 @@ services:
         - REG_BASIC_CREDENTIAL
         - REG_NPM_EMAIL
     environment:
-      - VERBOSE
       - DEBUG
       - BRANCH_NAME
       - BUILDKITE
@@ -148,7 +143,6 @@ services:
       args:
         - BUILDKITE_BUILD_NUMBER
     environment:
-      VERBOSE:
       DEBUG:
       SKIP_NAVIGATION_SCENARIOS:
     networks:

diff --git a/dockerfiles/Dockerfile.node b/dockerfiles/Dockerfile.node
@@ -21,7 +21,7 @@ RUN npm pack --verbose packages/plugin-koa/
 RUN npm pack --verbose packages/plugin-restify/
 
 # The maze-runner node tests
-FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner-releases:latest-v3-cli as node-maze-runner
+FROM 855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner-releases:v3.5.1-cli as node-maze-runner
 WORKDIR /app/
 COPY packages/node/ .
 COPY test/node test/node

diff --git a/packages/core/client.js b/packages/core/client.js
@@ -273,11 +273,6 @@ class Client {
     event._user = assign({}, event._user, this._user)
     event.breadcrumbs = this._breadcrumbs.slice()
 
-    if (this._session) {
-      this._session._track(event)
-      event._session = this._session
-    }
-
     // exit early if events should not be sent on the current releaseStage
     if (this._config.enabledReleaseStages !== null && !includes(this._config.enabledReleaseStages, this._config.releaseStage)) {
       this._logger.warn('Event not sent due to releaseStage/enabledReleaseStages configuration')
@@ -314,6 +309,16 @@ class Client {
         event._handledState.severityReason = { type: 'userCallbackSetSeverity' }
       }
 
+      if (event.unhandled !== event._handledState.unhandled) {
+        event._handledState.severityReason.unhandledOverridden = true
+        event._handledState.unhandled = event.unhandled
+      }
+
+      if (this._session) {
+        this._session._track(event)
+        event._session = this._session
+      }
+
       this._delivery.sendEvent({
         apiKey: event.apiKey || this._config.apiKey,
         notifier: this._notifier,

diff --git a/packages/core/session.d.ts b/packages/core/session.d.ts
@@ -0,0 +1,24 @@
+import Session from './types/session'
+
+interface MinimalEvent {
+  _handledState: {
+    unhandled: boolean
+  }
+}
+
+interface SessionJson {
+  id: string
+  startedAt: Date
+  events: {
+    handled: number
+    unhandled: number
+  }
+}
+
+export default class SessionWithInternals extends Session {
+  _track(event: MinimalEvent): void
+  toJSON(): SessionJson
+
+  public _handled: number
+  public _unhandled: number
+}