Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid optional properties in Turbo Module spec #534

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

yousif-bugsnag
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag commented Nov 26, 2024

Goal

Replace the use of optional properties with | undefined types in Turbo Module type definitions.

Design

This is in line with the type mappings in the React Native docs and is more representative of the native types to which they map.

Testing

Covered by a full CI run

Copy link

github-actions bot commented Nov 26, 2024

Browser bundle size

NPM build

Package
Before 210.63 kB
After 210.63 kB
± No change

CDN build

Unminified Minfied Minified + gzipped
Before 107.59 kB 40.60 kB 11.89 kB
After 107.59 kB 40.60 kB 11.89 kB
± No change No change No change

Code coverage

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
87.82%(+0%) 78.76%(+0%) 86.7%(+0%) 85.92%(+0%)

Generated against 080014d on 26 November 2024 at 10:49:06 UTC

@yousif-bugsnag yousif-bugsnag force-pushed the PLAT-13105/fix-turbo-module-types branch from 8fa051e to 080014d Compare November 26, 2024 10:45
@yousif-bugsnag yousif-bugsnag merged commit 8285b38 into next Nov 27, 2024
93 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-13105/fix-turbo-module-types branch November 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants