Skip to content

Commit

Permalink
run e2e tests over https
Browse files Browse the repository at this point in the history
  • Loading branch information
Dan Skinner committed Nov 25, 2024
1 parent 99b22a6 commit 61a543c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .buildkite/browser-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ steps:
- with: { browser: edge, version: latest }

# BrowserStack non-https
- label: ":browserstack: :{{ matrix.browser }}: {{ matrix.version }} Browser tests${EXTRA_STEP_LABEL}"
- label: ":browserstack: :{{ matrix.browser }}: {{ matrix.version }} Browser non-https tests${EXTRA_STEP_LABEL}"
depends_on: "browser-maze-runner-legacy-${USE_CDN_BUILD}"
timeout_in_minutes: 30
plugins:
Expand Down
2 changes: 1 addition & 1 deletion test/browser/features/device-id.feature
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Device ID persistence

# reload the page to prove the ID was persisted and not just available in
# memory somehow
When I navigate to the test URL "/retry-scenario"
When I navigate to the test URL "/docs/retry-scenario"
And I wait to receive a sampling request
And I click the element "send-first-span"
And I wait for 1 span
Expand Down
4 changes: 2 additions & 2 deletions test/browser/features/resource-load-spans.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Feature: Resource Load Spans
@requires_resource_load_spans
Scenario: Resource load spans are automatically instrumented (NPM build)
Given I set the sampling probability to "0.999999"
And I navigate to the test URL "/resource-load-spans"
And I navigate to the test URL "/docs/resource-load-spans"
And I wait to receive a sampling request

When I click the element "end-span"
Expand Down Expand Up @@ -33,7 +33,7 @@ Feature: Resource Load Spans
@requires_resource_load_spans
Scenario: Resource load spans are automatically instrumented (CDN build)
Given I set the sampling probability to "0.999999"
And I navigate to the test URL "/resource-load-spans"
And I navigate to the test URL "/docs/resource-load-spans"
And I wait to receive a sampling request

When I click the element "end-span"
Expand Down
2 changes: 1 addition & 1 deletion test/react-native/features/traceparent.feature
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Feature: Trace propagation headers
And I wait to receive 5 reflections

And I wait for 5 spans
Then every span string attribute "http.url" matches the regex "^https:\/\/.+:\d{4}\/reflect$"
Then every span string attribute "http.url" matches the regex "^http(s)?:\/\/.+:\d{4}\/reflect$"

And the reflection request method equals "GET"
And the reflection "X-Test-Header" header equals "test"
Expand Down

0 comments on commit 61a543c

Please sign in to comment.