add some logging

bugsnag · Dec 23, 2024 · 493186a · 493186a
1 parent f7fc7f4
commit 493186a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/packages/core/lib/span.ts b/packages/core/lib/span.ts
@@ -89,7 +89,11 @@ export function spanEndedToSpan (span: SpanEnded): Span {
 }
 
 export async function runSpanEndCallbacks (spanEnded: SpanEnded, logger: Logger, callbacks?: OnSpanEndCallbacks) {
-  if (!callbacks) return true
+  console.log(`[BugsnagPerformance] runSpanEndCallbacks for span: ${spanEnded.name}`)
+  if (!callbacks) {
+    console.log('[BugsnagPerformance] no callbacks to run')
+    return true
+  }
 
   const span = spanEndedToSpan(spanEnded)
   const callbackStartTime = performance.now()
@@ -103,6 +107,7 @@ export async function runSpanEndCallbacks (spanEnded: SpanEnded, logger: Logger,
         result = await result
       }
 
+      console.log('[BugsnagPerformance] callback result:', result)
       if (result === false) {
         shouldSample = false
         break
@@ -115,6 +120,8 @@ export async function runSpanEndCallbacks (spanEnded: SpanEnded, logger: Logger,
     const duration = millisecondsToNanoseconds(performance.now() - callbackStartTime)
     span.setAttribute('bugsnag.span.callbacks_duration', duration)
   }
+
+  console.log('[BugsnagPerformance] callbacks complete, shouldSample:', shouldSample)
   return shouldSample
 }
 

diff --git a/packages/platforms/react-native/lib/span-factory.ts b/packages/platforms/react-native/lib/span-factory.ts
@@ -40,12 +40,14 @@ export class ReactNativeSpanFactory extends SpanFactory<ReactNativeConfiguration
 
   private async processNativeSpan (span: NativeSpanInternal, endTime: number) {
     const spanEnded = span.end(endTime, this.sampler.spanProbability)
+    console.log(`[BugsnagPerformance] processing native span: ${spanEnded.name}`)
     const shouldSend = await runSpanEndCallbacks(spanEnded, this.logger, this.onSpanEndCallbacks)
 
     if (shouldSend) {
       const unixEndTimeNanos = (this.clock as ReactNativeClock).toUnixNanoseconds(endTime)
       const attributes = spanEnded.attributes.toObject()
       delete attributes['bugsnag.sampling.p']
+      console.log(`[BugsnagPerformance] ending native span with attributes: ${JSON.stringify(attributes)}`)
       NativeBugsnagPerformance?.endNativeSpan(spanEnded.id, spanEnded.traceId, unixEndTimeNanos, attributes)
     } else {
       NativeBugsnagPerformance?.discardNativeSpan(spanEnded.id, spanEnded.traceId)

diff --git a/test/react-native/features/fixtures/scenario-launcher/scenarios/NativeIntegrationScenario.js b/test/react-native/features/fixtures/scenario-launcher/scenarios/NativeIntegrationScenario.js
@@ -13,9 +13,12 @@ export const initialise = async (config) => {
 
   const onSpanEnd = [
     async (span) => {
+      console.log('[BugsnagPerformance] NativeIntegrationScenario onSpanEnd')
       if (span.name === 'JS parent span') {
+        console.log('[BugsnagPerformance] setting custom attribute on JS parent span')
         span.setAttribute('custom.js.attribute', 'JS span attribute')
       } else if (span.name === 'Native child span') {
+        console.log('[BugsnagPerformance] setting custom attribute on Native child span')
         span.setAttribute('custom.native.attribute', 'Native span attribute')
       }
       return true