[PLAT-5923] Improved thread recording #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a9e67d6.
nickdowell
changed the title
kstenerud
requested changes
Feb 10, 2021
kstenerud
approved these changes
Feb 16, 2021
This was referenced Feb 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Changeset
Added 2 new (private) methods on
BugsnagThread:+allThreads:callStackReturnAddresses:(replaces-[BSG_KSCrash captureThreads:depth:recordAllThreads:])+mainThreadOther threads are now suspended for a shorter period of time while their backtraces are being captured, and resumed before symbolication starts.
Testing
Manually tested to verify correctness and measure performance improvement.
Using a sample app, performance was measured by calling
notify()100 times in a loop to obtain reproducible figures for the execution time. The results were:.always.unhandledOnlyUnit test cases have been added to verify the new functionality.