Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-5624] Add E2E barebone tests #945

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Dec 17, 2020

Goal

Add E2E smoke tests that can run quickly to validate basic functionality.

Design

The tests are designed to verify a number of different areas of functionality within each scenario.

3 types of error are tested, since each type has a separate code path in the notifier:

  • Handled
  • Unhandled
  • OOM

The areas of functionality covered:

  • Sessions contain custom user ID
  • Overriding app version in config
  • Metadata from config and in OnError block
  • Metadata redaction
  • Presence of all app & device fields
  • Overriding unhandled flag (for handled errors only)
  • Leaving breadcrumbs
  • Modifying breadcrumbs in an OnBreadcrumb block
  • OnBreadcrumb, OnSendError and OnSession blocks are called as expected
  • Rejection of error in OnError block

Changeset

Added 3 new scenarios.

Testing

See BuildKite

@nickdowell nickdowell force-pushed the nickdowell/smoke-tests branch from 72a720d to 07ff7c7 Compare December 17, 2020 10:33
@nickdowell nickdowell changed the title [PLAT-5624] Add E2E smoke tests [PLAT-5624] Add E2E barebone tests Dec 17, 2020
@nickdowell nickdowell marked this pull request as ready for review December 17, 2020 13:22
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. I'll sweep these up into CI with one of my forthcoming tasks.

@nickdowell nickdowell merged commit 6ba3a6f into next Dec 18, 2020
@nickdowell nickdowell deleted the nickdowell/smoke-tests branch December 18, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants