5371 max persisted sessions #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5371-maxPersistedSessions
branch
from
07c6a55 to
6e19bb9
Compare
…w many unsent sessions will be kept before deleting the oldest.
kstenerud
force-pushed
the
5371-maxPersistedSessions
branch
from
6e19bb9 to
23a49ba
Compare
nickdowell
approved these changes
Dec 16, 2020
kattrali
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adding max persisted sessions config option to bring the library in line with the current notifier spec (PLAT-5371)
Testing
E2E tests are not possible because all persisted sessions are queued for sending immediately upon creating a new session. I was able to verify that only the configured number of sessions are persisted, and all others are deleted.