[PLAT-4646] Implement discardClasses configuration option #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Implements the
discardClasses
configuration option which contains strings or regular expressions that, when theBugsnagError.errorClass
matches, will cause the error to be discarded.Design
For unhandled errors the evaluation is performed at next launch because it's not possible to evaluate regular expressions in an async-safe manner at crash time.
Changeset
discardClasses
property toBugsnagConfiguration
-shouldDiscardErrorClass:
method toBugsnagConfiguration
BugsnagClient
to discard if-shouldDiscardErrorClass:
returnsYES
BugsnagErrorReportSink
to discard if-shouldDiscardErrorClass:
returnsYES
Testing
-shouldDiscardErrorClass:
with a variety ofdiscardClasses
values against a set of real-world error classes.