Add new config option: maxPersistedEvents #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
force-pushed
the
5111-maxPersistedEvents
branch
from
75fc9de to
40d7bf8
Compare
kattrali
reviewed
Dec 11, 2020
nickdowell
suggested changes
Dec 11, 2020
kstenerud
force-pushed
the
5111-maxPersistedEvents
branch
from
40d7bf8 to
cf17380
Compare
…many unsent events will be kept before deleting the oldest.
kstenerud
force-pushed
the
5111-maxPersistedEvents
branch
from
cf17380 to
1360415
Compare
nickdowell
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To harmonize configuration options, we need a maxPersistedEvents config option
Design
Add maxPersistedEvents to the configuration object
Testing
Updated unit tests to also verify maxPersistedEvents.
We can't test interrupted network connectivity, so I did some manual testing where I set the max to 2, generated 5 errors with airplane mode on, and then verified that only the last 2 events were kept and sent.