Fix missing header KSCrashReportWriter.h #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue introduced in 4368381. BugsnagConfiguration.h (a public header) gained a new include of the KSCrashReportWriter.h (private) header. This fix includes updates to the podpsec so that KSCrashReportWriter.h is now public, and also reverts the project setting "CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES" which I assume was set to allow the test target to compile. - Add public header in Bugsnag.podspec - Revert project setting allowing non modular includes - Add public header in Bugsnag target
|
Thanks, @mattyohe. I must have zoned out there. :) |
kattrali
added a commit
that referenced
this pull request
Feb 9, 2016
…ound Fix missing header KSCrashReportWriter.h
This was referenced Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
This resolves an issue introduced in 4368381. BugsnagConfiguration.h (a
public header) gained a new include of the KSCrashReportWriter.h
(private) header. This fix includes updates to the podpsec so that
KSCrashReportWriter.h is now public, and also reverts the project
setting "CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES" which I
assume was set to allow the test target to compile.